Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Don't depend on NIOFoundationCompat in NIOTransportServices o…
…n Linux (#209)" (#210) This reverts commit 40ffcde in PR #209. Unfortunately, Swift's behaviour around imports tends to be somewhat "leaky". In this case, the leak is that the dependency on the Package.swift allows downstream projects to import `NIOFoundationCompat` without needing to actually specify the package dependency. This has affected Hummingbird, which we noticed on our internal integration testing functionality: ``` hummingbird/Sources/Hummingbird/Codable/JSON/JSONCoding.swift:18:8: error: no such module 'NIOFoundationCompat' import NIOFoundationCompat ^ ``` cc @Joannis @adam-fowler for the Hummingbird report. Unfortunately, we can't make this change until we're willing to use a semver major to achieve it. There may be some argument for doing that now, as the semver major will be very cheap to adopt across the ecosystem. But we'll need to do this in a considered way. @Cyberbeni please feel free to reopen your PR targetting main, where we can discuss whether this is worth issuing a semver major for.
- Loading branch information