Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Linux build support. #19

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

TylerJaacks
Copy link

No description provided.

@TylerJaacks TylerJaacks requested a review from rauhul as a code owner July 25, 2024 22:40
@rauhul
Copy link
Collaborator

rauhul commented Jul 27, 2024

Thank you for the contribution @TylerJaacks, it looks like you still have a number of TODOs/FIXMEs left resolve before this is ready to be reviewed. Is that correct?

@TylerJaacks
Copy link
Author

Yes but I thought I would bring in a pull request to see if this could even be merged? If so I will continue to fix my TODOs if not I can just maintain this by myself. Thank you.

@rauhul
Copy link
Collaborator

rauhul commented Jul 30, 2024

Adding linux support is definitely something I'm happy to add to this repo!

@TylerJaacks
Copy link
Author

So the main issue here is that

I have no idea what is going on with these

-Wl,-exported_symbol,_eventHandlerShim \
-Wl,-exported_symbol,_eventHandler \

I'm not sure why they are here, building on Linux with these result in _eventHandlerShim file not being found and _eventHandler not being found. If I remove these on Linux it builds fine. I have tested them on my device, I have not tested them on the Simulator cause it is annoying to get setup in WSL, so I will have to install a Ubuntu VM.

I was hoping you would be able to help me figure this out.

In regards to the other TODOS they aren't mission critical I just don't like the names I chose the variables in the code and what I am using for environment variables.

Finally I think it would need to be tested to see if this still builds on macOS, I guess I will have to dig out my MacBook Pro and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants