Fix deprecated message it cannot handle in swift6 (in 5 mode) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using swift-language-mode 5 with Swift 6, I can't handle the deprecated message displayed for
ServiceContext.withValue.The conditional
#if swift(>=6.0)is only effective with swift-language-mode 6 and not with mode 5. I believe the correct specification is#if compiler(>=6.0).Additionally, the deprecated message always appears in Swift 5, which I also cannot handle.
This PR fix the issue so that warnings do not appear in swift-language-mode 5 and swift-language-mode 6 of Swift 6, as well as in Swift 5.10.