Skip to content

Commit

Permalink
Merge pull request #31 from apptentive/develop
Browse files Browse the repository at this point in the history
Release 5.1.3
  • Loading branch information
frankus authored Jul 26, 2018
2 parents a5cd40d + 46ea040 commit 4f494cb
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 13 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ This document lets you know what has changed in the React Native module. For cha
- [Android Changelog](https://github.com/apptentive/apptentive-android/blob/master/CHANGELOG.md)
- [iOS Changelog](https://github.com/apptentive/apptentive-ios/blob/master/CHANGELOG.md)

# 2018-07-26 - v5.1.3

- Fix check for registered status on iOS

# 2018-07-26 - v5.1.2

- Fix missing dependency in podspec
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="apptentive_distribution">React Native</string>
<string name="apptentive_distribution_version">5.1.2</string>
<string name="apptentive_distribution_version">5.1.3</string>
</resources>
2 changes: 1 addition & 1 deletion apptentive-react-native.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "apptentive-react-native"
s.version = "5.1.2"
s.version = "5.1.3"
s.summary = "Apptentive SDK module for React Native"

s.description = <<-DESC
Expand Down
13 changes: 3 additions & 10 deletions ios/RNApptentiveModule.m
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ - (dispatch_queue_t)methodQueue
if (configuration) {
configuration.appID = configurationDictionary[@"appleID"];
configuration.distributionName = @"React Native";
configuration.distributionVersion = @"5.1.2";
configuration.distributionVersion = @"5.1.3";
[Apptentive registerWithConfiguration:configuration];

[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(messageCenterUnreadCountChangedNotification:) name:ApptentiveMessageCenterUnreadCountChangedNotification object:nil];
Expand All @@ -62,11 +62,8 @@ - (dispatch_queue_t)methodQueue
[self sendEventWithName:@"onAuthenticationFailed" body:@{ @"reason": reasonString }];
};

if (Apptentive.shared != nil) {
resolve(configuration.distributionName);
} else {
rejecter(kRejectCode, @"Unable to register", nil);
}
_registered = YES;
resolve(configuration.distributionName);
} else {
rejecter(kRejectCode, @"Configuration returned nil", nil);
}
Expand Down Expand Up @@ -412,10 +409,6 @@ - (dispatch_queue_t)methodQueue

RCT_EXPORT_MODULE()

- (BOOL)isRegistered {
return Apptentive.shared != nil;
}

- (NSArray<NSString *> *)supportedEvents
{
return @[@"onUnreadMessageCountChanged", @"onAuthenticationFailed"];
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "apptentive-react-native",
"version": "5.1.2",
"version": "5.1.3",
"description": "React Native Module for Apptentive SDK",
"main": "js/index.js",
"scripts": {
Expand Down

0 comments on commit 4f494cb

Please sign in to comment.