Support defining ClusterLogForwarding filter list as an object #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to define logforwarding filters in multiple places in the hierarchy, and so would like to have a nice easily-mergeable dict instead of the list - similar to how we define the pipelines, inputs and outputs as well.
I built this feature in a backwards-compatible way - if filters are already defined as a list, they are kept as-is.
Of course, it is only possible to use either lists or objects within the entire hieararchy of a single cluster - if they are mixed, reclass will fail. Still, this allows us to migrate "legacy" filter lists as we find them.
Alternatively, I could change the implementation to be analogous to the other fields where we perform this kind of processing. Then we would have to update all existing filter definitions in our hierarchy, as it'd be a breaking change. I only know of the filters for loki central audit logging; I don't know in how many other places this is used.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog.