This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Added a flag --prefer-css-page-size which enables PreferCSSPageSize #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the travis build fails, but running this in production for 16 days now and it works like a charm! |
|
Sorry for the lack of updates @poison ! And yeah, the CI is very flakey. I should look into it. I greatly appreciate your PR, and I'll try my best to look into it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new chromium API supports the PreferCSSPageSize flag, which let CSS determine the page size and margins. I had to upgrade chrome in order to make this work.
Any feedback is welcome!