Ignore sporadic warnings that make the env crash and jobs terminate #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindr93
requested changes
Jul 31, 2020
There was a problem hiding this comment.
The mujoco warnings look good. I believe we had it in the earlier versions, but removed it for some reason. Do you remember why? If we can't remember, let's include the exception anyway.
I prefer to keep the default viewer speed at 1/2 run-time since that works better with most envs. Can you revert that change back? Other than that, LGTM.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common warning that crashes training is when policy accidentally makes a lot of contacts and fills up the contact buffer. These updates gracefully handle these warnings.