Reenable MLS tests on HIP

arborx · Apr 9, 2024 · 1662d9c · 1662d9c
1 parent 466efb7
commit 1662d9c
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 46 deletions.
diff --git a/test/tstInterpDetailsMLSCoefficients.cpp b/test/tstInterpDetailsMLSCoefficients.cpp
@@ -45,17 +45,6 @@ interpolate(ExecutionSpace const &space, SourceValues const &source_values,
 
 BOOST_AUTO_TEST_CASE_TEMPLATE(mls_coefficients, DeviceType, ARBORX_DEVICE_TYPES)
 {
-  // FIXME_HIP: the CI fails with:
-  // fatal error: in "mls_coefficients_edge_cases<Kokkos__Device<Kokkos__HIP_
-  // Kokkos__HIPSpace>>": std::runtime_error: Kokkos::Impl::ParallelFor/Reduce<
-  // HIP > could not find a valid team size.
-  // The error seems similar to https://github.com/kokkos/kokkos/issues/6743
-#ifdef KOKKOS_ENABLE_HIP
-  if (std::is_same_v<typename DeviceType::execution_space, Kokkos::HIP>)
-  {
-    return;
-  }
-#endif
   using ExecutionSpace = typename DeviceType::execution_space;
   using MemorySpace = typename DeviceType::memory_space;
   ExecutionSpace space{};
@@ -137,17 +126,6 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(mls_coefficients, DeviceType, ARBORX_DEVICE_TYPES)
 BOOST_AUTO_TEST_CASE_TEMPLATE(mls_coefficients_edge_cases, DeviceType,
                               ARBORX_DEVICE_TYPES)
 {
-  // FIXME_HIP: the CI fails with:
-  // fatal error: in "mls_coefficients_edge_cases<Kokkos__Device<Kokkos__HIP_
-  // Kokkos__HIPSpace>>": std::runtime_error: Kokkos::Impl::ParallelFor/Reduce<
-  // HIP > could not find a valid team size.
-  // The error seems similar to https://github.com/kokkos/kokkos/issues/6743
-#ifdef KOKKOS_ENABLE_HIP
-  if (std::is_same_v<typename DeviceType::execution_space, Kokkos::HIP>)
-  {
-    return;
-  }
-#endif
   using ExecutionSpace = typename DeviceType::execution_space;
   using MemorySpace = typename DeviceType::memory_space;
   ExecutionSpace space{};

diff --git a/test/tstInterpMovingLeastSquares.cpp b/test/tstInterpMovingLeastSquares.cpp
@@ -21,18 +21,6 @@
 BOOST_AUTO_TEST_CASE_TEMPLATE(moving_least_squares, DeviceType,
                               ARBORX_DEVICE_TYPES)
 {
-  // FIXME_HIP: the CI fails with:
-  // fatal error: in "mls_coefficients_edge_cases<Kokkos__Device<Kokkos__HIP_
-  // Kokkos__HIPSpace>>": std::runtime_error: Kokkos::Impl::ParallelFor/Reduce<
-  // HIP > could not find a valid team size.
-  // The error seems similar to https://github.com/kokkos/kokkos/issues/6743
-#ifdef KOKKOS_ENABLE_HIP
-  if (std::is_same_v<typename DeviceType::execution_space, Kokkos::HIP>)
-  {
-    return;
-  }
-#endif
-
   using ExecutionSpace = typename DeviceType::execution_space;
   using MemorySpace = typename DeviceType::memory_space;
   ExecutionSpace space{};
@@ -111,18 +99,6 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(moving_least_squares, DeviceType,
 BOOST_AUTO_TEST_CASE_TEMPLATE(moving_least_squares_edge_cases, DeviceType,
                               ARBORX_DEVICE_TYPES)
 {
-  // FIXME_HIP: the CI fails with:
-  // fatal error: in "mls_coefficients_edge_cases<Kokkos__Device<Kokkos__HIP_
-  // Kokkos__HIPSpace>>": std::runtime_error: Kokkos::Impl::ParallelFor/Reduce<
-  // HIP > could not find a valid team size.
-  // The error seems similar to https://github.com/kokkos/kokkos/issues/6743
-#ifdef KOKKOS_ENABLE_HIP
-  if (std::is_same_v<typename DeviceType::execution_space, Kokkos::HIP>)
-  {
-    return;
-  }
-#endif
-
   using ExecutionSpace = typename DeviceType::execution_space;
   using MemorySpace = typename DeviceType::memory_space;
   ExecutionSpace space{};