Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of getIndexable in HappyTreeFriends #1163

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Sep 26, 2024

First push is the test to make sure CI gets the warning.
Second push is the fix.

@aprokop aprokop added bug Something isn't working testing Anything to do with tests and CI labels Sep 26, 2024
@aprokop
Copy link
Contributor Author

aprokop commented Sep 26, 2024

Warning from GCC build on 0d18194:

In file included from <snip>/test/tstIndexableGetter.cpp:14:
In file included from <snip>/src/ArborX_LinearBVH.hpp:27:
In file included from <snip>/src/details/ArborX_DetailsTreeTraversal.hpp:15:
<snip>/src/details/ArborX_DetailsHappyTreeFriends.hpp:56:12:
warning: returning reference to local temporary object [-Wreturn-stack-address]
    return bvh._indexable_getter(getValue(bvh, i));
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@aprokop aprokop merged commit 07dacc7 into arborx:master Sep 30, 2024
2 checks passed
@aprokop aprokop deleted the fix_get_indexable branch September 30, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Anything to do with tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants