Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #31: highlight character differences in JSON lines #37

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Munawwar
Copy link
Contributor

@Munawwar Munawwar commented Jul 19, 2024

A proposed solution for Issue #31.

Before:
before

After:
after

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2024

CLA assistant check
All committers have signed the CLA.

@tbeseda
Copy link
Member

tbeseda commented Jul 26, 2024

This looks really promising! I have to do some updates today and will look at merging. Thanks for contributing @Munawwar !

@tbeseda tbeseda merged commit 245fa38 into architect:main Jul 29, 2024
2 of 14 checks passed
@Munawwar
Copy link
Contributor Author

@tbeseda I made the "least resistance" change. However what if we could improve this further? E.g + and - prefix to the lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants