Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump prettier from 3.2.2 to 3.2.4 #447

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Bump prettier from 3.2.2 to 3.2.4 #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
622d8b3
Bump prettier from 3.2.2 to 3.2.4
dependabot[bot] Jan 26, 2024
49eb6f6
Update `prettier` version in template installation docs
per1234 Jan 26, 2024
cc6f87c
Install referenced schema in "npm:validate" task
per1234 Jan 26, 2024
c972e1a
Install referenced schema in "eslint:validate" task
per1234 Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"{{.WORKFLOW_TEMPLATES_PATH}}/test-python-poetry-task.yml" \
"{{.WORKFLOWS_PATH}}"

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-workflows-task/Taskfile.yml

Check warning on line 80 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

80:121 [line-length] line too long (131 > 120 characters)

Check warning on line 80 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

80:121 [line-length] line too long (131 > 120 characters)
ci:validate:
desc: Validate GitHub Actions workflows against their JSON schema
vars:
Expand Down Expand Up @@ -397,6 +397,10 @@
SCHEMA_URL: https://json.schemastore.org/eslintrc.json
SCHEMA_PATH:
sh: task utility:mktemp-file TEMPLATE="eslintrc-schema-XXXXXXXXXX.json"
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/partial-eslint-plugins.json
PARTIAL_ESLINT_PLUGINS_SCHEMA_URL: https://json.schemastore.org/partial-eslint-plugins.json
PARTIAL_ESLINT_PLUGINS_PATH:
sh: task utility:mktemp-file TEMPLATE="partial-eslint-plugins-schema-XXXXXXXXXX.json"
DATA_PATH: workflow-templates/assets/check-javascript/.eslintrc.yml
# ajv-cli identifies YAML-format data files by their file extension, so renaming is required:
# https://github.com/ajv-validator/ajv-cli/issues/117
Expand All @@ -406,14 +410,16 @@
sh: task utility:mktemp-folder TEMPLATE="eslintrc-validate-XXXXXXXXXX"
cmds:
- wget --quiet --output-document="{{.SCHEMA_PATH}}" {{.SCHEMA_URL}}
- wget --quiet --output-document="{{.PARTIAL_ESLINT_PLUGINS_PATH}}" {{.PARTIAL_ESLINT_PLUGINS_SCHEMA_URL}}
- |
cd "{{.WORKING_FOLDER}}" # Workaround for https://github.com/npm/cli/issues/3210
npx ajv-cli@{{.SCHEMA_DRAFT_4_AJV_CLI_VERSION}} validate \
--all-errors \
-s "{{.SCHEMA_PATH}}" \
-r "{{.PARTIAL_ESLINT_PLUGINS_PATH}}" \
-d "{{.PROJECT_FOLDER}}/{{.DATA_PATH}}"

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-files-task/Taskfile.yml

Check warning on line 422 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

422:121 [line-length] line too long (127 > 120 characters)

Check warning on line 422 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

422:121 [line-length] line too long (127 > 120 characters)
general:check-filenames:
desc: Check for non-portable filenames
cmds:
Expand Down Expand Up @@ -446,7 +452,7 @@
echo
echo "Prohibited characters found in filenames"
echo "See:"
echo "https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions:~:text=except%20for%20the%20following"

Check warning on line 455 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

455:121 [line-length] line too long (142 > 120 characters)

Check warning on line 455 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

455:121 [line-length] line too long (142 > 120 characters)
false
}
- |
Expand Down Expand Up @@ -479,11 +485,11 @@
echo
echo "Reserved filenames found"
echo "See:"
echo "https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions:~:text=use%20the%20following-,reserved%20names,-for%20the%20name"

Check warning on line 488 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

488:121 [line-length] line too long (169 > 120 characters)

Check warning on line 488 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

488:121 [line-length] line too long (169 > 120 characters)
false
}

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-general-formatting-task/Taskfile.yml

Check warning on line 492 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

492:121 [line-length] line too long (140 > 120 characters)

Check warning on line 492 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

492:121 [line-length] line too long (140 > 120 characters)
general:check-formatting:
desc: Check basic formatting style of all files
cmds:
Expand All @@ -494,7 +500,7 @@
fi
- ec

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/spell-check-task/Taskfile.yml

Check warning on line 503 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

503:121 [line-length] line too long (127 > 120 characters)

Check warning on line 503 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

503:121 [line-length] line too long (127 > 120 characters)
general:check-spelling:
desc: Check for commonly misspelled words
deps:
Expand All @@ -502,7 +508,7 @@
cmds:
- poetry run codespell

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-files-task/Taskfile.yml

Check warning on line 511 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

511:121 [line-length] line too long (127 > 120 characters)

Check warning on line 511 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

511:121 [line-length] line too long (127 > 120 characters)
general:check-symlinks:
desc: Check for bad symlinks
cmds:
Expand All @@ -529,7 +535,7 @@
false
}

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/spell-check-task/Taskfile.yml

Check warning on line 538 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

538:121 [line-length] line too long (127 > 120 characters)

Check warning on line 538 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

538:121 [line-length] line too long (127 > 120 characters)
general:correct-spelling:
desc: Correct commonly misspelled words where possible
deps:
Expand All @@ -537,7 +543,7 @@
cmds:
- poetry run codespell --write-changes

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-prettier-formatting-task/Taskfile.yml

Check warning on line 546 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

546:121 [line-length] line too long (141 > 120 characters)

Check warning on line 546 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

546:121 [line-length] line too long (141 > 120 characters)
general:format-prettier:
desc: Format all supported files with Prettier
deps:
Expand Down Expand Up @@ -737,6 +743,10 @@
NPM_BADGES_SCHEMA_URL: https://json.schemastore.org/npm-badges.json
NPM_BADGES_SCHEMA_PATH:
sh: task utility:mktemp-file TEMPLATE="npm-badges-schema-XXXXXXXXXX.json"
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/partial-eslint-plugins.json
PARTIAL_ESLINT_PLUGINS_SCHEMA_URL: https://json.schemastore.org/partial-eslint-plugins.json
PARTIAL_ESLINT_PLUGINS_PATH:
sh: task utility:mktemp-file TEMPLATE="partial-eslint-plugins-schema-XXXXXXXXXX.json"
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/prettierrc.json
PRETTIERRC_SCHEMA_URL: https://json.schemastore.org/prettierrc.json
PRETTIERRC_SCHEMA_PATH:
Expand All @@ -761,6 +771,7 @@
- wget --quiet --output-document="{{.ESLINTRC_SCHEMA_PATH}}" {{.ESLINTRC_SCHEMA_URL}}
- wget --quiet --output-document="{{.JSCPD_SCHEMA_PATH}}" {{.JSCPD_SCHEMA_URL}}
- wget --quiet --output-document="{{.NPM_BADGES_SCHEMA_PATH}}" {{.NPM_BADGES_SCHEMA_URL}}
- wget --quiet --output-document="{{.PARTIAL_ESLINT_PLUGINS_PATH}}" {{.PARTIAL_ESLINT_PLUGINS_SCHEMA_URL}}
- wget --quiet --output-document="{{.PRETTIERRC_SCHEMA_PATH}}" {{.PRETTIERRC_SCHEMA_URL}}
- wget --quiet --output-document="{{.SEMANTIC_RELEASE_SCHEMA_PATH}}" {{.SEMANTIC_RELEASE_SCHEMA_URL}}
- wget --quiet --output-document="{{.STYLELINTRC_SCHEMA_PATH}}" {{.STYLELINTRC_SCHEMA_URL}}
Expand All @@ -773,6 +784,7 @@
-r "{{.ESLINTRC_SCHEMA_PATH}}" \
-r "{{.JSCPD_SCHEMA_PATH}}" \
-r "{{.NPM_BADGES_SCHEMA_PATH}}" \
-r "{{.PARTIAL_ESLINT_PLUGINS_PATH}}" \
-r "{{.PRETTIERRC_SCHEMA_PATH}}" \
-r "{{.SEMANTIC_RELEASE_SCHEMA_PATH}}" \
-r "{{.STYLELINTRC_SCHEMA_PATH}}" \
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"github-label-sync": "2.3.1",
"markdown-link-check": "^3.11.2",
"markdownlint-cli": "^0.37.0",
"prettier": "^3.2.2"
"prettier": "^3.2.4"
},
"dependencies": {
"js-yaml": "^4.1.0"
Expand Down
6 changes: 6 additions & 0 deletions workflow-templates/assets/check-npm-task/Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ tasks:
NPM_BADGES_SCHEMA_URL: https://json.schemastore.org/npm-badges.json
NPM_BADGES_SCHEMA_PATH:
sh: task utility:mktemp-file TEMPLATE="npm-badges-schema-XXXXXXXXXX.json"
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/partial-eslint-plugins.json
PARTIAL_ESLINT_PLUGINS_SCHEMA_URL: https://json.schemastore.org/partial-eslint-plugins.json
PARTIAL_ESLINT_PLUGINS_PATH:
sh: task utility:mktemp-file TEMPLATE="partial-eslint-plugins-schema-XXXXXXXXXX.json"
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/prettierrc.json
PRETTIERRC_SCHEMA_URL: https://json.schemastore.org/prettierrc.json
PRETTIERRC_SCHEMA_PATH:
Expand All @@ -56,6 +60,7 @@ tasks:
- wget --quiet --output-document="{{.ESLINTRC_SCHEMA_PATH}}" {{.ESLINTRC_SCHEMA_URL}}
- wget --quiet --output-document="{{.JSCPD_SCHEMA_PATH}}" {{.JSCPD_SCHEMA_URL}}
- wget --quiet --output-document="{{.NPM_BADGES_SCHEMA_PATH}}" {{.NPM_BADGES_SCHEMA_URL}}
- wget --quiet --output-document="{{.PARTIAL_ESLINT_PLUGINS_PATH}}" {{.PARTIAL_ESLINT_PLUGINS_SCHEMA_URL}}
- wget --quiet --output-document="{{.PRETTIERRC_SCHEMA_PATH}}" {{.PRETTIERRC_SCHEMA_URL}}
- wget --quiet --output-document="{{.SEMANTIC_RELEASE_SCHEMA_PATH}}" {{.SEMANTIC_RELEASE_SCHEMA_URL}}
- wget --quiet --output-document="{{.STYLELINTRC_SCHEMA_PATH}}" {{.STYLELINTRC_SCHEMA_URL}}
Expand All @@ -68,6 +73,7 @@ tasks:
-r "{{.ESLINTRC_SCHEMA_PATH}}" \
-r "{{.JSCPD_SCHEMA_PATH}}" \
-r "{{.NPM_BADGES_SCHEMA_PATH}}" \
-r "{{.PARTIAL_ESLINT_PLUGINS_PATH}}" \
-r "{{.PRETTIERRC_SCHEMA_PATH}}" \
-r "{{.SEMANTIC_RELEASE_SCHEMA_PATH}}" \
-r "{{.STYLELINTRC_SCHEMA_PATH}}" \
Expand Down
2 changes: 1 addition & 1 deletion workflow-templates/check-prettier-formatting-task.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ The tool dependencies of this workflow are managed by [npm](https://www.npmjs.co
Add the dependencies by running this command:

```text
npm install --save-dev prettier@^3.2.2
npm install --save-dev prettier@^3.2.4
```

Commit the resulting changes to the `package.json` and `package-lock.json` files.
Expand Down
Loading