Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions setup fixes #496

Merged
merged 5 commits into from
Oct 2, 2023
Merged

GitHub Actions setup fixes #496

merged 5 commits into from
Oct 2, 2023

Conversation

ralphlange
Copy link
Contributor

@ralphlange ralphlange commented Oct 2, 2023 •
edited
Loading

Some fixes and updates of the GitHub Actions setup:

  • Update ci-scripts.
  • Set TIRPC=YES on Linux.
  • Clean up the settings files by using 'include' and the ci-scripts provided defaults.
  • Add a job for Ubuntu-20.04.
  • Update internal checkout action to v3.

@ralphlange ralphlange force-pushed the gha-ci-fixes branch 4 times, most recently from 707a12d to eb92522 Compare October 2, 2023 13:03
@ralphlange ralphlange force-pushed the gha-ci-fixes branch 2 times, most recently from 2147167 to 69fe40c Compare October 2, 2023 16:05
@ralphlange ralphlange changed the title Gha ci fixes GitHub Actions setup fixes Oct 2, 2023
@ralphlange ralphlange marked this pull request as ready for review October 2, 2023 16:45
@ralphlange
Copy link
Contributor Author

I think this is ready to review and merge.

The remaining failures of the 'os' setup on ubuntu-latest (=22.04) are related to API incompatibilities between the OS-supplied HDF5 version on Ubuntu 22 and the calls in ADCore and not related to the GitHub Actions builds.

MarkRivers
MarkRivers approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@MarkRivers MarkRivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MarkRivers MarkRivers merged commit 076bd45 into areaDetector:master Oct 2, 2023
3 of 7 checks passed
bsobhani pushed a commit to bsobhani/ADCore that referenced this pull request Apr 1, 2024
@MarkRivers
Merge pull request areaDetector#496 from ralphlange/gha-ci-fixes
aec5b30 
GitHub Actions setup fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkRivers MarkRivers MarkRivers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphlange @MarkRivers