Fixup build with deb12 #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complicates forwards compatibility
No dllimport/export
Add case with -fvisibility=hidden to enforce use of API macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of somewhat related build fixes.
For my Linux builds I use
-fvisibility=hidden -fvisibility-inlines-hiddento catch dllimport/export errors. This is stricter than MSVC. Which is why the lack ofNDPLUGIN_APIonclass NDFileHDF5Datasethas not been fatal so far. However, I think this omission was not intentional, and adding this as a CI check should prevent repeats.The main issue is that
libADTestUtilityhas no API macros at all. For the time being this can be handled by only linking a static version.Is
ADTestUtilityintended for external use?If not, then eg. changing
LIBRARY=toTEST_LIBRARY=will prevent it from being installed. Otherwise, it needs an*API.hand added decorations.The last change is to omit
-DH5_NO_DEPRECATED_SYMBOLS. I think this makes sense for a developer making changes to the HDF5 plugin. For others, it only complicates portability. Also, the comment in the Makefile mentions ubuntu 12.04, which is increasingly historical.