ADApp/pluginSrc/NDFileTIFF.cpp: restore dedicated handling of 32-bit … #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…integers. Having the 32-bit case fall through to the 64-bit case resulted in corrupted data most of the time, and this restores previous behavior without affecting the new 64-bit support.
|
fixes #519 |
MarkRivers
reviewed
Nov 12, 2024
There was a problem hiding this comment.
I think the original logic and this logic are both incorrect.
pAttribute->getValue() should be passed a datatype that matches the pointer it is passed. pAttribute->getValue() does the type conversion from the actual type of the attribute to datatype passed to it.
So the calls should be
pAttribute->getValue(NDAttrInt32, &value.i32);
and
pAttribute->getValue(NDAttrInt64, &value.i64);
The existing code will probably work OK on little-endian machines, but not on big-endian machines.
My modified code is still not perfect because UInt32 and UInt64 will be printed as if they are signed.
|
I have create a new PR that fixes the issues with this one, and adds testing. #520 |
|
Closing this because #520 is a better fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…integers. Having the 32-bit case fall through to the 64-bit case resulted in corrupted data most of the time, and this restores previous behavior without affecting the new 64-bit support.