Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spent fuel resource IDs are missing #9

Closed
abachma2 opened this issue Apr 6, 2023 · 2 comments
Closed

Spent fuel resource IDs are missing #9

abachma2 opened this issue Apr 6, 2023 · 2 comments
Assignees
@abachma2
Labels
Comp:Output This issue has to do with the output component of the code or document. (writing to databases, etc.) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Bug Something is wrong or broken. This issue or PR is related to a bug in code.

Comments

@abachma2
Copy link
Collaborator

abachma2 commented Apr 6, 2023

Current behavior:

  • The spent fuel materials are not getting registered into the Resources Table with unique IDs or as children of the fresh fuel
  • 4 tests in tests/integration_tests.py pass and 2 fail. The 2 failing tests are testing the contents of the Resources Table in each case run.

Expected behavior:

  • The spent fuel materials are registered in the Resources Table with unique IDs and as children of the fresh fuel resources
  • All 6 tests in tests/integration_tests.py pass
@abachma2 abachma2 self-assigned this Apr 6, 2023
@abachma2 abachma2 added Comp:Output This issue has to do with the output component of the code or document. (writing to databases, etc.) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Bug Something is wrong or broken. This issue or PR is related to a bug in code. labels Apr 6, 2023
@abachma2 abachma2 mentioned this issue Apr 6, 2023
Merged
@abachma2
Copy link
Collaborator Author

abachma2 commented Jun 7, 2023

I have discovered that this issue is because of missing functionality in the Python API of Cyclus, and not because of an error in this code.

This was referenced Jun 19, 2023
Merged
Merged
@abachma2
Copy link
Collaborator Author

Closed with the merging of #15.

@abachma2 abachma2 mentioned this issue Jul 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abachma2 abachma2

Labels
Comp:Output This issue has to do with the output component of the code or document. (writing to databases, etc.) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Bug Something is wrong or broken. This issue or PR is related to a bug in code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abachma2