Fix recording resources issue #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urces Conflicts: openmcyclus/DepleteReactor.py
The ReactorEvents table is created and some of the columns can be written to it, but the column names are wrong. The spent fuel resources are partially written to the Resources table, but only up through the TimeCreated column. Not sure why the other columns can't be written.
Needed to adjust the Quantity to a double. The table is full now. The Parent 1 isn't correct, but I'm not sure how to get it to be correct and match the state_id of the parent (i.e. before the state id is bumped)
abachma2
added
Comp:Output
If fuel is to be transmuted at each cycle end, then the spent fuel resources don't need to be recording each time fuel is transmuted. This also captures all of the fuel that is dischraged from a reactor, not just the transmuted fuel. This only has an impact when a facility is decommissioned during a simulation
Specifying the decom_transmute_all in Cycamore means that all of the fuel discharged from the reactor at decommissioning gets transmuted, and thus recorded in the Resources database
ZoeRichter
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Looks good to me - I'm not seeing any glaring issues in the code. The CI breaking is a concern, but from what I read in your PRs, it seems like you're aware of the issue, the cause is external to this PR, and you intend to address it in a separate PR, so in this instance I think it should be alright to merge.
|
Thanks for the review @ZoeRichter. The contents of the PR don't rely on the other PR, so this is ready to be merged on my end. Is it ready to be merged on your end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken functionality of the spent fuel not being recorded as separate resources from the fresh fuel. Merging this PR will close Issue #9. All tests are passing locally, the CI is still broken (see issue #12), to be updated in a later PR.