Change depletion time step sizes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depletion time steps are now in seconds, based on the optional, user-defined dt parameter for Cyclus
nsryan2
approved these changes
Jul 18, 2024
|
Not at the moment. That would fall under the integration tests, which aren't working because of the seg fault (see #12). |
|
Gottcha, I'm happy to merge. I'll make a note in that issue so it doesn't get lost. |
|
Would you want this part of the unit test to be updated? https://github.com/arfc/openmcyclus/blob/3723a289f14f1061e38752ee6ba3d6b8205bf316/tests/unit_tests/test_depletion.py#L48C13-L51C32 |
|
No. That function is to run the depletion solver just for the unit tests. It's not connected to the method in Cyclus to call the depletion solver. I can't update the test function to match with the Cyclus method because the |
|
Ok, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the depletion time step size for OpenMC from assuming each time step is 30 days to using the
dtparameter in Cyclus to define the time step size.