Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-Up Commented lines #158

Open
katyhuff opened this issue Feb 25, 2021 · 0 comments · May be fixed by #159
Open

Clean-Up Commented lines #158

katyhuff opened this issue Feb 25, 2021 · 0 comments · May be fixed by #159
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Style Is related to coding style guide compliance (e.g. PEP8 or google C++ style guide).

Comments

@katyhuff
Copy link
Member

Some PRs (e.g. #156) are being approved and merged with commented cruft (unused code). For example, in the snakefile, the commented-out cruft lines should be deleted.:

DBS = ["UIUC_2050_cost"]
SCENARIOS = ["costScenario"]
FOLDER = ["UIUC_2050_cost_costScenario_model"]

# DBS = ["UIUC_2050_land"]
# SCENARIOS = ["landScenario"]
# FOLDER = ["UIUC_2050_land_landScenario_model"]

This issue can be closed when someone has gone through the repository and removed this and all other commented-out lines that are not in use.
@katyhuff katyhuff added Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Style Is related to coding style guide compliance (e.g. PEP8 or google C++ style guide). labels Feb 25, 2021
@katyhuff katyhuff mentioned this issue Feb 25, 2021
Merged
@robfairh robfairh linked a pull request Feb 25, 2021 that will close this issue
Draft
@robfairh robfairh self-assigned this Feb 25, 2021
@robfairh robfairh added Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) and removed Status:1-New No one has claimed this issue yet. It is in need of solving. labels Feb 25, 2021
@robfairh robfairh removed their assignment Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Style Is related to coding style guide compliance (e.g. PEP8 or google C++ style guide).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deleted commented lines robfairh/pride
2 participants
@katyhuff @robfairh