Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix turbine #156

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Fix turbine #156

merged 4 commits into from
Feb 25, 2021

Conversation

samgdotson
Copy link
Collaborator

This pull request fixes the turbine issue, which counted NTURBINE as TURBINE.

Current results for COST are
costScenario_all_emissions_co2eq
costScenario_all_emissions_ewaste
costScenario_all_emissions_spent-fuel
costScenario_chw_capacity
costScenario_chw_generation
costScenario_elc_capacity
costScenario_elc_generation
costScenario_ind_capacity
costScenario_ind_generation
costScenario_vcl_capacity
costScenario_vcl_generation

Current results for LAND are:
landScenario_all_emissions_co2eq
landScenario_all_emissions_ewaste
landScenario_all_emissions_spent-fuel
landScenario_chw_capacity
landScenario_chw_generation
landScenario_elc_capacity
landScenario_elc_generation
landScenario_ind_capacity
landScenario_ind_generation
landScenario_vcl_capacity
landScenario_vcl_generation

robfairh
robfairh reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@robfairh robfairh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samgdotson It looks good to me.

Two things:

  • delete: run_cost_scenario.txt
  • the solution to data_parser.py is fine for the moment. Should we aim for a more permanent solution or the juice isn't worth the squeeze?

@robfairh robfairh added Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Bug Something is wrong or broken. This issue or PR is related to a bug in code. labels Feb 25, 2021
@robfairh robfairh mentioned this pull request Feb 25, 2021
Closed
@robfairh robfairh merged commit d63ee77 into arfc:master Feb 25, 2021
@samgdotson samgdotson deleted the fix-turbine branch February 25, 2021 15:01
@katyhuff katyhuff mentioned this pull request Feb 25, 2021
Open
katyhuff
katyhuff reviewed Feb 25, 2021
View reviewed changes
temoa-uiuc/Snakefile
SCENARIOS = ["costScenario"]
FOLDER = ["UIUC_2050_cost_costScenario_model"]

# DBS = ["UIUC_2050_land"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#158

@robfairh robfairh mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katyhuff katyhuff katyhuff left review comments

@robfairh robfairh robfairh approved these changes

Assignees
No one assigned
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Bug Something is wrong or broken. This issue or PR is related to a bug in code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samgdotson @katyhuff @robfairh