Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add TextNow to USERS.md #20602

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

nikolai-momot
Copy link
Contributor

@nikolai-momot nikolai-momot commented Oct 30, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Addresses #20561

@nikolai-momot nikolai-momot requested review from a team as code owners October 30, 2024 21:20
Copy link

bunnyshell bot commented Oct 30, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign your commit ( DCO check )

@nikolai-momot
Copy link
Contributor Author

Please sign your commit ( DCO check )

@pasha-codefresh done

@blakepettersson blakepettersson enabled auto-merge (squash) October 31, 2024 13:48
@blakepettersson
Copy link
Member

@nikolai-momot with the merge from master you'll need to run it again

In your local branch, run: git rebase HEAD~2 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin chore/add-textnow

Signed-off-by: Nikolai.Momot <nikolai.momot@textnow.com>
auto-merge was automatically disabled October 31, 2024 13:56

Head branch was pushed to by a user without write access

@blakepettersson blakepettersson merged commit 79abbbe into argoproj:master Oct 31, 2024
22 checks passed
@blakepettersson
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants