Skip to content

Commit

Permalink
feat(argo-rollouts): add annotations for notifications secret (#2777)
Browse files Browse the repository at this point in the history
* feat(argo-rollouts): Most users of Argo-rollouts may store secrets on vault which allows to auto inject secrets directly to secrets object using annotations.
Signed-off-by:Mohamed Ragab <mohamed.ragab@hellofresh.com>

Signed-off-by: Mohamed Ragab <mohamed.ragab@hellofresh.com>

* Fix indentation

Signed-off-by: Mohamed Ragab <mohamed.ragab@hellofresh.com>

---------

Signed-off-by: Mohamed Ragab <mohamed.ragab@hellofresh.com>
Co-authored-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>
  • Loading branch information
mohamedragab2024 and mkilchhofer authored Jun 22, 2024
1 parent 02949b1 commit 2ba2eb3
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 2 deletions.
4 changes: 2 additions & 2 deletions charts/argo-rollouts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v1.7.0
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.36.0
version: 2.36.1
home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
keywords:
Expand All @@ -19,4 +19,4 @@ annotations:
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Bump argo-rollouts to v1.7.0
description: Add annotations for notifications secret
1 change: 1 addition & 0 deletions charts/argo-rollouts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ For full list of changes please check ArtifactHub [changelog].
| kubeVersionOverride | string | `""` | Override the Kubernetes version, which is used to evaluate certain manifests |
| nameOverride | string | `nil` | String to partially override "argo-rollouts.fullname" template |
| notifications.notifiers | object | `{}` | Configures notification services |
| notifications.secret.annotations | object | `{}` | Annotations to be added to the notifications secret |
| notifications.secret.create | bool | `false` | Whether to create notifications secret |
| notifications.secret.items | object | `{}` | Generic key:value pairs to be inserted into the notifications secret |
| notifications.templates | object | `{}` | Notification templates |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ kind: Secret
metadata:
name: argo-rollouts-notification-secret
namespace: {{ .Release.Namespace | quote }}
{{- with .Values.notifications.secret.annotations }}
annotations:
{{- range $key, $value := . }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- end }}
labels:
app.kubernetes.io/component: {{ .Values.controller.component }}
{{- include "argo-rollouts.labels" . | nindent 4 }}
Expand Down
2 changes: 2 additions & 0 deletions charts/argo-rollouts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,8 @@ notifications:
# -- Generic key:value pairs to be inserted into the notifications secret
items: {}
# slack-token:
# -- Annotations to be added to the notifications secret
annotations: {}

# -- Configures notification services
notifiers: {}
Expand Down

0 comments on commit 2ba2eb3

Please sign in to comment.