support only setting some parameters on first create #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31453
approved these changes
Apr 12, 2024
chelma
reviewed
Apr 15, 2024
Comment on lines
+19
to
+32
| if (expectedTraffic is None): | ||
| expectedTraffic = MINIMUM_TRAFFIC | ||
|
|
||
| if (spiDays is None): | ||
| spiDays = DEFAULT_SPI_DAYS | ||
|
|
||
| if (historyDays is None): | ||
| historyDays = DEFAULT_HISTORY_DAYS | ||
|
|
||
| if (replicas is None): | ||
| replicas = DEFAULT_REPLICAS | ||
|
|
||
| if (pcapDays is None): | ||
| pcapDays = DEFAULT_S3_STORAGE_DAYS |
There was a problem hiding this comment.
Recommend not changing the values of the arguments themselves; Python is pass-by-reference so this should change the value of the variable in the outside scope that you're invoking the constructor from. A better way would be to just set the self.* members based on the conditional instead. That will prevent "surprises" from the caller's perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support cluster-create only having some arguments set. Previously if any of the arguments weren't set, the defaults were used for everything. This makes it so the defaults are only used for what isn't set.
Testing
Tried with different parameters used and make sure the defaults weren't used for those provided.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.