Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix according to breaking changes in r1cs-std #126

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Fix according to breaking changes in r1cs-std #126

merged 4 commits into from
Jan 6, 2024

Conversation

autquis
Copy link
Contributor

@autquis autquis commented Jan 3, 2024 •
edited
Loading

Just a refactor according to arkworks-rs/r1cs-std#135 (and see the comment below)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@autquis autquis requested a review from a team as a code owner January 3, 2024 12:03
@autquis autquis requested review from z-tech, Pratyush and mmagician and removed request for a team January 3, 2024 12:03
@autquis
Copy link
Contributor Author

autquis commented Jan 4, 2024 •
edited
Loading

Now, this PR is also a fix according to breaking changes in arkworks-rs/r1cs-std#121

@autquis autquis changed the title Change nonnative according to r1cs-std Fix according to breaking changes in r1cs-std Jan 4, 2024
Pratyush
Pratyush approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Pratyush Pratyush merged commit a135971 into arkworks-rs:main Jan 6, 2024
4 checks passed
@autquis
Copy link
Contributor Author

autquis commented Jan 7, 2024 •
edited
Loading

Thanks for merging! @Pratyush
However, I did not see that arkworks-rs/r1cs-std#136 got merged, so the Cargo.toml is incorrect now. (I wanted to update it after add-convert-traits-to-prelude getting merged). Could you update it, please?
Or I can create a new PR if necessary.

@Pratyush
Copy link
Member

Pratyush commented Jan 7, 2024

Oops, made a new PR #127 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@autquis @Pratyush