Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on ark-relations/std #147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mzabaluev
Copy link

@mzabaluev mzabaluev commented Jul 28, 2024

Description

The dependency on ark-relations/std is entirely unneeded.
Currently it adds some dependency dead weight for us due to pulling an outdated version of tracing-subscriber (arkworks-rs/snark#356).


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@mzabaluev mzabaluev requested a review from a team as a code owner July 28, 2024 19:58
@mzabaluev mzabaluev requested review from Pratyush, mmagician and weikengchen and removed request for a team July 28, 2024 19:58
@Pratyush
Copy link
Member

I think it would be preferable to update the dependency in ark-relations. If you'd like to look into that I can help with that, otherwise we can look into it in a little while.

@mzabaluev
Copy link
Author

I think it would be preferable to update the dependency in ark-relations.

Sure, but why not remove useless dependencies from the dependency tree as well? This potentially improves build times for library's consumers, and I can't see any downsides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants