This repository has been archived by the owner on Jul 18, 2018. It is now read-only.
Add RawGenericKey widget #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd really like to see some splinter tests for this. Any chance you want to take a stab at it? Considering that the admin is one of the biggest parts of Armstrong, it's pretty concerning that there's no test coverage for it. |
|
The likelihood of getting this tested with Splinter before the end of the month seems low. Let's release the functionality then add tests in early April. |
added 4 commits
May 23, 2012 11:39
…id, on the next page load the object picker will be initialized properly
| class RawGenericKeyWidget(Widget): | ||
| template = "admin/hatband/widgets/rawgenerickey.html" | ||
|
|
||
| class Media: |
There was a problem hiding this comment.
This should respect ARMSTRONG_ADMIN_PROVIDE_STATIC (see 905d2ae)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visual search based generickey widget can work with a lot of additional work as seen in the WellNodeInline, but it doesn't provide the easy searching/filtering that the django raw picker does. The RawGenericKey widget provides an interim solution that uses django's existing raw foreign key picker in combination with some javascript glue to make it easy to pick an arbitrary object out of the system.