Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DateTime.d.ts #835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update DateTime.d.ts #835

wants to merge 1 commit into from

Conversation

jinyi0521
Copy link

When you want to use step, it has bug about min and max values

Description

I wanted to use only step option, but I have to set up min and max values. And it has bug that it doesnt work as I intended to. So I changed min and max as a optional typing. It works.

Motivation and Context

  1. Someone like me want to use only step, but this code doesnt allow us to use it.
  2. Yes it does

Checklist

[x ] I have not included any built dist files (us maintainers do that prior to a new release)
[x ] I have added tests covering my changes
[ x] All new and existing tests pass
[x ] My changes required the documentation to be updated
  [x ] I have updated the documentation accordingly
  [ x] I have updated the TypeScript 1.8 type definitions accordingly
  [ x] I have updated the TypeScript 2.0+ type definitions accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant