Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'selecting the 31st day of previous month' bug #848

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Macy6
Copy link

@Macy6 Macy6 commented Jan 4, 2023

Description

Fixed 'selecting the 31st of previous month' bug

Motivation and Context

Checklist

[ ] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[ ] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly

@tinhtony2506
Copy link

When we will release this one?

@tinhtony2506
Copy link

@arqex Please focus this issue

@baileygranam
Copy link

👍 would love to see this resolved as well

@AndrewDaneSpackman
Copy link

I would love to see this change merged in and updated. This has been an issue for quite some time, and I would like to see it finally get resolved.

@AndrewDaneSpackman
Copy link

@arqex @Macy6 Is there an ETA on this fix being pushed? It is causing some serious issues with our date selection!

@suraj975
Copy link

suraj975 commented Feb 11, 2023

Until the code is not merged, @AndrewDaneSpackman you can use renderDay function to handle this situation.

https://codesandbox.io/s/trusting-allen-xpfthw?file=/src/App.js

@AndrewDaneSpackman
Copy link

AndrewDaneSpackman commented Mar 17, 2023

Until the code is not merged, @AndrewDaneSpackman you can use renderDay function to handle this situation.

https://codesandbox.io/s/trusting-allen-xpfthw?file=/src/App.js

I have attempted to implement this fix and, while the displayed value is now correct, the value set in state is not; it is the previous value. As such, this is not useable as a solution for me.

@AndrewDaneSpackman
Copy link

AndrewDaneSpackman commented Mar 17, 2023

@arqex Any updates on this? Apart from this issue, this component does everything else we need it to. Maybe even forgoing the rendering of previous/next months days instead, so they cannot be selected?

@deep-121
Copy link

deep-121 commented Nov 2, 2023

@arqex Any updates on this?

@lukezavrel
Copy link

lukezavrel commented Feb 14, 2024

Until the code is not merged, @AndrewDaneSpackman you can use renderDay function to handle this situation.
https://codesandbox.io/s/trusting-allen-xpfthw?file=/src/App.js

I have attempted to implement this fix and, while the displayed value is now correct, the value set in state is not; it is the previous value. As such, this is not useable as a solution for me.

I have rewritten this workaround to fit my needs, so it might help you as well. It should set the value correctly and preserve time
https://codesandbox.io/p/sandbox/trusting-hertz-lddqcs?file=%2Fsrc%2FApp.js

@yuan9090
Copy link

I fork the repository and fix this issue. Try https://www.npmjs.com/package/@iftek/react-datetime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants