use ripgrep instead of vscode findFiles #909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really sure why tests are failing, I will checkout your branch locally and do some tests |
|
It's actually a cache issue since we create/remove files during tests in the |
|
Superseded by #910 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ggrossetie this attempt uses
ripgrepdirectly (getting the right path to the version embedded in vscode usingvscode-ripgreppublished by Microsoft).Significantly increases the performance, because ripgrep by default excludes gitignored files and symlinks.
Had to disregard the cancellation token used before. Not sure that is an issue.
This could be replaced by the upgraded findFiles once it is finalised by the vscode team.
Curious to know what you think.
resolves #907 to a great extent