Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aws provider level default_tags configuration #195

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

reweeden
Copy link
Contributor

@reweeden reweeden commented Jul 12, 2024

This even applies to resources created within the cumulus modules, so we no longer need to pass the default tags in through the tags variable for the cumulus and data-persistence modules.

NOTE: This will generate a terraform diff for existing tagged resources because terraform tracks two separate tags* fields. tags are the resource specific tags which will no longer include the deployment tag while tags_all will include the resource specific tags merged together with the provider level defaults. Diffs should show that the tags field had the Deployment tag removed, while tags_all should remain unchanged (or in some cases have the Deployment tag added if that resource was not tagged before).

Copy link
Collaborator

@lindsleycj lindsleycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link
Collaborator

@mikedorfman mikedorfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@reweeden reweeden merged commit 588a28e into master Aug 14, 2024
2 checks passed
@reweeden reweeden deleted the rew/provider-default-tags branch August 14, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants