Bump the handlebars helpers #36
Conversation
|
@jonschlinkert I am using the 0.6.0 handlebars-helpers combination for which the helpers have been tested against. |
|
@LaurentGoderre how extensive are the tests? I'm not sure how compatible the 0.6.0 helpers are. |
|
@jonschlinkert I just updated the tests. 0.6.0 was not quite compatible but I think I fixed it. Can you review the change to this as well as the tests I wrote? |
|
@jonschlinkert I also ran the tests in grunt-assemble with this and it all passed. |
|
@jonschlinkert any objection with me merging this? |
|
@LaurentGoderre I'm testing this out by running it through a few projects. I think the reason that we haven't updated this is because when Have you tried the latest version of |
|
I haven't tested the latest but I know that the version here fixes the issues mentioned at the top. That is what I'm trying to solve. I was thinking of bumping it and bumping minor version and do the same to assemble so users can choose which version they want. |
index.js
Outdated
| } | ||
| helpers(null, options); |
There was a problem hiding this comment.
this should just be helpers(options), otherwise the options aren't used in this version of handlebars-helpers
|
We'll definitely have to bump the minors. Most of the helpers are working fine but upgrading a project will require template changes. I commented in the code on a change that should be made, then I think this is okay to merge. We'll then need to update |
|
Any update on this? |
|
Sorry for the delay. I'll get this published and update |
Fixes assemble/grunt-assemble#31