Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: thick discs only receive projected radius #167

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

fjebaker
Copy link
Member

@fjebaker fjebaker commented Sep 9, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 86.20% and project coverage change: +0.06% 🎉

Comparison is base (9f3e2bf) 69.27% compared to head (334ad20) 69.34%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   69.27%   69.34%   +0.06%     
==========================================
  Files          66       66              
  Lines        2734     2730       -4     
==========================================
- Hits         1894     1893       -1     
+ Misses        840      837       -3     
Files Changed Coverage Δ
src/geometry/discs.jl 0.00% <ø> (-4.55%) ⬇️
src/tracing/precision-solvers.jl 69.44% <50.00%> (ø)
src/geometry/discs/datum-plane.jl 77.77% <66.66%> (+14.14%) ⬆️
src/geometry/discs/thick-disc.jl 80.00% <81.81%> (+1.42%) ⬆️
src/geometry/discs/polish-doughnut.jl 100.00% <100.00%> (ø)
src/geometry/discs/shakura-sunyaev.jl 91.66% <100.00%> (-0.65%) ⬇️
...ransfer-functions/cunningham-transfer-functions.jl 97.29% <100.00%> (ø)
src/utils.jl 40.98% <100.00%> (+4.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjebaker fjebaker merged commit 5985d97 into main Sep 9, 2023
1 check passed
@fjebaker fjebaker deleted the fergus/thick-disc-rework branch September 9, 2023 23:21
@fjebaker fjebaker linked an issue Sep 9, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thick discs should be parameters of cylindrical radius only
2 participants