-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test matrix and add scheduled tests #210
Open
matt-graham
wants to merge
13
commits into
main
Choose a base branch
from
mmg/update-test-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 29 29
Lines 3146 3146
=======================================
Hits 2929 2929
Misses 217 217 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates test matrix to run tests across all supported Python versions (currently Python 3.8 – 3.12)
and operating systems. Also adds weekly scheduled test runs to resolve #208.Given this makes the test matrix quite large
(15 combinations of OS and Python version), and Python 3.8 and Python 3.9 are both out of the recommended support window of both SPEC0 and NEP29, I would also recommend we consider dropping Python 3.8 and Python 3.9 support (in a separate PR).EDIT: Appears that there are not Windows wheels available for
healpy
/pyssht
and we're getting a segfault somewhere when using MacOS / Python 3.9+ so reverting to only testing on Ubuntu + (MacOS, Python 3.8) for now.