revert: rm databases,iagon #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This is messed up - this is failing locally because the tests depend on |
|
Yeah can confirm that locally if you run npm run coverage && echo "success"You will see Reading issues ... others have seen it but have said it's "fixed" ... is it our config of lerna 🫠 |
mixmix
commented
Jun 14, 2024
Comment on lines
+41
to
+61
| const level1 = createLevelDBStorage({ dbPath: "./db1" }) | ||
| const db1 = await createRxDatabase({ | ||
| name: 'level-1-db', | ||
| storage: level1, | ||
| password: 'password-1' | ||
| }) | ||
| await db1.addCollections(collections) | ||
| await db1.todo.insert({ id: '1', name: 'milk' }) | ||
| const record1 = await db1.todo.findOne('1').exec() | ||
| expect(record1._data.name).toBe('milk') | ||
|
|
||
| const level2 = createLevelDBStorage({ dbPath: "./db2" }) | ||
| const db2 = await createRxDatabase({ | ||
| name: 'level-2-db', | ||
| storage: level2, | ||
| password: 'password-2' | ||
| }) | ||
| await db2.addCollections(collections) | ||
| await db2.todo.insert({ id: '2', name: 'potatoes' }) | ||
| const record2 = await db2.todo.findOne('2').exec() | ||
| expect(record2._data.name).toBe('potatoes') |
There was a problem hiding this comment.
I wasn't sure how to test mulit-instance ok-ness... so I just spun up a db and did a read/write?
Totally up for this being better
mixmix
commented
Jun 14, 2024
Comment on lines
+12
to
+19
| "coverage": "run-s coverage:indexdb coverage:inmemory coverage:leveldb", | ||
| "coverage:indexdb": "npm --prefix packages/indexdb run coverage", | ||
| "coverage:inmemory": "npm --prefix packages/inmemory run coverage", | ||
| "coverage:leveldb": "npm --prefix packages/leveldb run coverage", | ||
| "test": "run-s test:indexdb test:inmemory test:leveldb", | ||
| "test:indexdb": "npm --prefix packages/indexdb run test", | ||
| "test:inmemory": "npm --prefix packages/inmemory run test", | ||
| "test:leveldb": "npm --prefix packages/leveldb run test", |
There was a problem hiding this comment.
I got zero time to waste on lerna swallowing errors.
I feel sad about this, but I also have a life to live
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is designed to remove the
databaseandiagonpackagesChecklist:
packages/database,packages/iagondatabasementions in the root README.mdlerna, which I have chosen to side-step with verbose commands to ensure CI actually works 💀TODO (in future PRs):
/docs