-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 add support for files with no extension #577
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 90.86% 91.89% +1.03%
==========================================
Files 8 8
Lines 580 617 +37
==========================================
+ Hits 527 567 +40
+ Misses 53 50 -3
☔ View full report in Codecov by Sentry. |
Thank you @olirwin! The tests failed, can you fix them? |
Should remove warnings in tests due to double quoted strings
Fixed as much as I could understand (there were 2 failing tests, one due to linter warnings, the other to test coverage). The other tests were just being auto cancelled. |
Solved this: add support for files with no extension #577 tests:
finished OK Here you can see dot-files with icons and file without extension with icon, and also can be file only from dots: how to assign it to me ? and make me permission to commit branch and PR ? |
Description
Updated the way the key is computed to allow for files without an extension to get icons.