Bitbucket use 9.0.0 eap03 #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done by removing flag that skips bitbucket integration
com.atlassian.util.concurrent is no longer provided by Bitbucket and io.atlassian.util.concurrent (its replacement and newer version) should be used instead
…installPermissionResourceFilter. Use correct URI builder method in AddQueryParamSlackFunction
djansons-atlassian
changed the title
djansons-atlassian
requested review from
ssu2-atl,
mvlasovatl,
yevhenhr and
ysun-atl
and removed request for
ssu2-atl
ysun-atl
previously approved these changes
Jun 3, 2024
djansons-atlassian
force-pushed
the
bitbucket-use-9.0.0-eap03-version-attempt2
branch
from
c343c93 to
68b2311
Compare
| <banningExcludes> | ||
| <exclude>com.atlassian.security:atlassian-secure-random</exclude> | ||
| <exclude>com.atlassian.fugue:fugue</exclude> | ||
| <exclude>com.google.code.gson:gson</exclude> |
There was a problem hiding this comment.
Looks like this is the only way forward when upgrading amps - https://community.developer.atlassian.com/t/com-google-code-gson-gson-is-a-banned-dependency/78867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enabled and fixed Bitbucket func tests
Fixed
UserLinkFuncTest#confirmThenRemoveConfirmationFromRegularAccountby removing theSlackLinkUninstallPermissionResourceFilter. Previously, this filter was implementingResourceFilter, but it didn't have any annotations on any resources to apply it, meaning it was never run. I can't see any resources that need to have this filter applied, so deleting it seems like the way to go. The closest thing I can find is the deleteTeam endpoint, but this is already protected by @SlackLinkAdministerPermission.Fixed
ConfigurationWebTestby passing a URI to the URI builder instead of a URL encoded URI