NONE eslint services directory #2436
Conversation
src/services/micros/lifecycle.ts
Outdated
| Message: string; | ||
| Type?: string; | ||
| Subject?: string; | ||
| Message?: string; |
There was a problem hiding this comment.
Curious about this change, should we really make our typing looser?
There was a problem hiding this comment.
Where these are currently used it is doing a direct assignment from an any coming from parsing json or yaml. We could keep these tighter in their definition but would need more validation when assigning objects to these interfaces
There was a problem hiding this comment.
I think we should do that IMHO, otherwise we will need to check if it is defined or not everywhere
There was a problem hiding this comment.
I have updated LifecycleData back to having them as set properties and added undefined checks after assignment.
I left LifecycleMessageData with optionals on its fields for now as it is only used in one place of the code right after being converted from json
What's in this PR?
Enable eslint in services directory
Why
More lint
Added feature flags
None
Affected issues
NONE
How has this been tested?
Unit tests
Whats Next?
more lint