Skip to content

Issues: attestate/ERC4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14 Open 34 Closed
14 Open 34 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Is ERC4973 backwards compatible with ERC721
#63 opened Feb 12, 2023 by umerarif01
@TimDaub
3
Replace function getHash() with eip-5267
#62 opened Jan 20, 2023 by TimDaub
Make most external interface functions overrideable like e.g. OZ's ERC721 implementation
#61 opened Jan 12, 2023 by TimDaub
@TimDaub
Implement burn and issue auth
#60 opened Jan 12, 2023 by TimDaub
@TimDaub
2
An additional bytes calldata data to give and take could help extending the interface's functionality
#59 opened Jan 12, 2023 by TimDaub
implement eip-5267 for structured eip-712 domain retrieval
#49 opened Sep 4, 2022 by TimDaub
2
consider making _mint private so that it is absolutely not used by implementers
#48 opened Sep 4, 2022 by TimDaub
testTakeWithDifferentTokenURI
#47 opened Aug 23, 2022 by ra-phael
Consider using vm.prank instead of account abstraction in Badges.t.sol
#45 opened Aug 15, 2022 by grp06
2
Consider adding totalSupply
#44 opened Aug 9, 2022 by rahulrumalla
1
Is it a problem that testTakeEOA and testGiveEOA produce the same validation signature? question Further information is requested
#42 opened Aug 4, 2022 by TimDaub
2
Now that function burn was renamed to function unequip we can't distinguish between someone disassociating themselves or "trashing" an item and someone unequipping it
#36 opened Jul 8, 2022 by TimDaub
consider foundry recommendation on how to test EIP-712
#25 opened Jun 24, 2022 by TimDaub
set up a linter that checks if files all use two spaces
#10 opened Jun 17, 2022 by TimDaub
ProTip! no:milestone will show everything without a milestone.