SAML assertion signing using HSM #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add signatureFunction as option for custom signing algorithm -allows signing from key server or Hardware Security Module (HSM)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using an HSM or signing server for assertion signing is the most secure way to store private keys. These transactions typically need to take place over an asynchronous connection.
Added support for asynchronous XML signing using custom functions provided by the host application. I have created the relevant PR to xml-crypto and those have been published in xml-crypto@1.5.3
References
Fixes #63
Testing
Unit tests have been created using async XML signing and a custom signing function.
Checklist
master