Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

[WIP] Decreasing the false positive ratio with new pre-filters #66

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

[WIP] Decreasing the false positive ratio with new pre-filters #66

wants to merge 10 commits into from

Conversation

radekk
Copy link
Contributor

@radekk radekk commented Oct 23, 2020 •
edited
Loading

Description

This PR is meant to reduce the number of false positives. Multiple improvements include:

  • Ignoring non-printable ASCII characters.
  • Reducing 35% of words detected in a secret to 30%.
  • Ignore a content of ./dist directory.
  • Ignore a content of package.json and package-lock.json files.
  • Ignore common regular expression patterns.

Therefore:

  • Remove legacy symlink to webtask binary.
  • Do not call a Slack trigger by default.
  • Update NVM version in the Dockerfile.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@radekk radekk changed the title Decreasing the false positive ratio with new pre-filters [WIP] Decreasing the false positive ratio with new pre-filters Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@radekk