Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export bulk go #26

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Export bulk go #26

merged 5 commits into from
Dec 18, 2024

Conversation

corkrean
Copy link
Contributor

this is meant to serve as an example of how to use pagination and cursors with export bulk.

one thing I'm unsure about here is if EOF is a good indicator that all relationships have been exported?

@corkrean corkrean requested a review from vroldanbet December 13, 2024 21:27
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it generally looks good; I identified an issue with stream errors - please have a look.

I suggest not putting the example under code-examples since there are already other top-level code examples. I would also like to suggest (not a blocker) to use export-bulk as folder name, following the conventions in the repository.

code-examples/go/exportBulk/main.go Outdated Show resolved Hide resolved
code-examples/go/exportBulk/main.go Outdated Show resolved Hide resolved
code-examples/go/exportBulk/main.go Outdated Show resolved Hide resolved
code-examples/go/exportBulk/main.go Outdated Show resolved Hide resolved
corkrean and others added 3 commits December 16, 2024 13:19
Co-authored-by: Víctor Roldán Betancort <vroldanbet@users.noreply.github.com>
@corkrean
Copy link
Contributor Author

I suggest not putting the example under code-examples since there are already other top-level code examples

@vroldanbet, what do you mean by this? I did not see any other top-level examples.

@vroldanbet
Copy link
Contributor

@corkrean

@vroldanbet, what do you mean by this? I did not see any other top-level examples.

example: https://github.com/authzed/examples/tree/main/spicedb-as-library

so your example should be moved to /bulk-export instead of code-examples/bulkExport

@corkrean
Copy link
Contributor Author

@vroldanbet

Hmm. We plan to add more examples, and I'm worried things will get messy if we keep everything at the top level.

Do you have any thoughts on moving /spicedb-as-library to /code-examples/go/spicedb-as-library?

@vroldanbet
Copy link
Contributor

@corkrean it would direct links to it. To me this whole repository is a "code examples" repository, so it's a stylistic choice between a very long root of the repo, or a very long code-examples directory. I'm not going to push back if you feel strongly.

@corkrean corkrean requested a review from vroldanbet December 17, 2024 19:06
@vroldanbet
Copy link
Contributor

@corkrean what I actually meant was: add your example to code-examples and leave spicedb-as-library (and others) where they are so we don't break URL links.

@corkrean
Copy link
Contributor Author

@vroldanbet

Oh I see. Done.

@vroldanbet vroldanbet merged commit 29054d2 into authzed:main Dec 18, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants