-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export bulk go #26
Export bulk go #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it generally looks good; I identified an issue with stream errors - please have a look.
I suggest not putting the example under code-examples
since there are already other top-level code examples. I would also like to suggest (not a blocker) to use export-bulk
as folder name, following the conventions in the repository.
Co-authored-by: Víctor Roldán Betancort <vroldanbet@users.noreply.github.com>
@vroldanbet, what do you mean by this? I did not see any other top-level examples. |
example: https://github.com/authzed/examples/tree/main/spicedb-as-library so your example should be moved to |
Hmm. We plan to add more examples, and I'm worried things will get messy if we keep everything at the top level. Do you have any thoughts on moving /spicedb-as-library to /code-examples/go/spicedb-as-library? |
@corkrean it would direct links to it. To me this whole repository is a "code examples" repository, so it's a stylistic choice between a very long root of the repo, or a very long |
@corkrean what I actually meant was: add your example to |
38af00e
to
e2cbded
Compare
Oh I see. Done. |
this is meant to serve as an example of how to use pagination and cursors with export bulk.
one thing I'm unsure about here is if EOF is a good indicator that all relationships have been exported?