Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

190 working directory unintuitive selection of runs #192

Merged

Conversation

KrissiHub
Copy link
Contributor

No description provided.

@KrissiHub KrissiHub requested a review from mwever October 7, 2024 13:40
@mwever
Copy link
Collaborator

mwever commented Oct 7, 2024

There are several files with a suffix " 2.py". Is this intentional? Generally speaking, I do not think that it is a good practice to have blanks in filenames as these are typically weird to handle across systems. Also it seems to me as if these files are duplicates of some original files?

Copy link
Collaborator

@mwever mwever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

deepcave/runs/converters/deepcave.py Show resolved Hide resolved
deepcave/runs/converters/optuna 2.py Outdated Show resolved Hide resolved
deepcave/plugins/hyperparameter/parallel_coordinates 2.py Outdated Show resolved Hide resolved
deepcave/plugins/hyperparameter/configuration_cube 2.py Outdated Show resolved Hide resolved
docs/converters/bohb.rst Outdated Show resolved Hide resolved
docs/converters/custom_converters.rst Outdated Show resolved Hide resolved
docs/converters/deepcave.rst Show resolved Hide resolved
docs/converters/smac.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@mwever mwever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@mwever mwever merged commit 9b35ab8 into development Nov 4, 2024
3 checks passed
@mwever mwever deleted the 190-working-directory-unintuitive-selection-of-runs branch November 4, 2024 09:03
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants