Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-existent 'RUNNING' status for runs #97

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fix non-existent 'RUNNING' status for runs #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29a1b26
Ignore running BOHB runs instead of assigning non-existent `RUNNING` …
helegraf Nov 10, 2023
73e477a
Update CHANGELOG.md
helegraf Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Version 1.1.4

## Bug-Fixes
- Don't convert BOHB runs with status 'running' (consistent with SMAC).

# Version 1.1.3

## Bug-Fixes
Expand Down
3 changes: 1 addition & 2 deletions deepcave/runs/converters/bohb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ def from_path(cls, path):

first_starttime = None
for bohb_run in bohb.get_all_runs():

times = bohb_run.time_stamps
starttime = times["started"]
endtime = times["finished"]
Expand Down Expand Up @@ -77,7 +76,7 @@ def from_path(cls, path):
if "SUCCESS" in status or "TERMINATED" in status or "COMPLETED" in status:
status = Status.SUCCESS
elif "RUNNING" in status or "QUEUED" in status or "REVIEW" in status:
status = Status.RUNNING
continue
else:
status = Status.CRASHED

Expand Down
Loading