-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added v #1474
Added v #1474
Conversation
@avelino the tool is written in python, but can be useful in go, what you thing about it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look good to me
@avelino maybe you could show me what's wrong? |
LBTM. we even didn't add travis/gimme. I think we don't need to add it too. |
@kirillDanshin Could you please explain me why? «we even didn't add travis/gimme» sounds as unconstructive criticism to me. |
@corpix Why it's written in Python instead of Go? |
@geovanisouza92 because:
|
It does not look good to me either. |
You don't like a tool just because it is not written in Go. Okay, I got the point. |
Do not get me wrong, it seems like a great tool. But the list is about Go, not about Python. We could not revise the code, and apply the same pattern we applied to the other PRs, we would have to open many exceptions, it would not be fair to others. |
Yes, this will be unfair. Well, rules are rules, this is ok.
|
@PotHix I don't support an idea to get rid of the things written in programming languages other than Go(because they could be useful for other people), so I won't, sorry :) |
No problem at all, I was just following your own argument: |
This is a uniform tool to manage toolchain versions. It manages only Go and Node.js versions at this time but, in theory, could be extended to manage any other language toolchain.
Goals of this tool are:
Make sure that you've checked the boxes below before you submit PR: