Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added v #1474

Closed
wants to merge 1 commit into from
Closed

Added v #1474

wants to merge 1 commit into from

Conversation

corpix
Copy link

@corpix corpix commented Jun 28, 2017

This is a uniform tool to manage toolchain versions. It manages only Go and Node.js versions at this time but, in theory, could be extended to manage any other language toolchain.
Goals of this tool are:

  • to be simple "one file" solution
  • which does not require any installation or modification of bash/zsh/*rc files
  • written in pure Python 3 without any other dependencies than python and git binary

  • github.com repo: https://github.com/corpix/v
  • godoc.org: It have no godoc, tool is implemented in pure Python without dependencies
  • goreportcard.com: None

Make sure that you've checked the boxes below before you submit PR:

Some items are unchecked because this is just utility, not Go package.

  • I have added my package in alphabetical order
  • I know that this package was not listed before
  • I have added godoc link to the repo and to my pull request
  • I have added coverage service link to the repo and to my pull request
  • I have added goreportcard link to the repo and to my pull request
  • I have read Contribution guidelines, maintainers note and Quality standard.

@cassiobotaro
Copy link
Collaborator

@avelino the tool is written in python, but can be useful in go, what you thing about it?

Copy link
Owner

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look good to me

@corpix
Copy link
Author

corpix commented Jul 13, 2017

@avelino maybe you could show me what's wrong?

@kirillDanshin
Copy link
Contributor

LBTM. we even didn't add travis/gimme. I think we don't need to add it too.

@corpix
Copy link
Author

corpix commented Jul 20, 2017

@kirillDanshin Could you please explain me why? «we even didn't add travis/gimme» sounds as unconstructive criticism to me.
I think this tool could be helpful for developers who use go to test the code with different versions of the toolchain. You have gvm in the list, so why not add a tool which has an alternative point of view on problems which gvm solves?

@geovanisouza92
Copy link

@corpix Why it's written in Python instead of Go?

@corpix
Copy link
Author

corpix commented Jul 20, 2017

@geovanisouza92 because:

  1. it exists in almost every linux distribution
  2. this tool is intended to be a solution which does not require a system with pre-installed go toolchain
  3. I don't like an idea of "binary distribution" for the software because I don't trust other people and don't want others to trust me(python code is transparent and could be easily reviewed by community in contrast to binary release)

@crgimenes
Copy link
Contributor

It does not look good to me either.
Consider rewriting in Go.

@crgimenes crgimenes closed this Jul 20, 2017
@corpix
Copy link
Author

corpix commented Jul 20, 2017

You don't like a tool just because it is not written in Go. Okay, I got the point.

@crgimenes
Copy link
Contributor

Do not get me wrong, it seems like a great tool. But the list is about Go, not about Python. We could not revise the code, and apply the same pattern we applied to the other PRs, we would have to open many exceptions, it would not be fair to others.

@corpix
Copy link
Author

corpix commented Jul 20, 2017

Yes, this will be unfair. Well, rules are rules, this is ok.
But following this rule some tools which are already in list should be rejected because their repositories does not contain a Go code:

gobrew, gvm and rodent solves a similar set of problems v is trying to solve

@PotHix
Copy link
Contributor

PotHix commented Jul 26, 2017

@corpix You're right on this one. There is an issue for almost the same purpose (#1446), please comment there about this.

Please provide separate PR's with your arguments to remove each of the libs mentioned. :)

@corpix
Copy link
Author

corpix commented Jul 27, 2017

@PotHix I don't support an idea to get rid of the things written in programming languages other than Go(because they could be useful for other people), so I won't, sorry :)

@PotHix
Copy link
Contributor

PotHix commented Jul 27, 2017

No problem at all, I was just following your own argument: But following this rule some tools which are already in list should be rejected because their repositories does not contain a Go code. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants