Improved Circle Drawing Algorithm. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Is this ready to merge now? |
|
It should be good to go, though some improvements could be made. |
|
Thank you for working on this! |
The small bump is not because of your algorithm, but rather how SDL draw lines. See JuliaMultimedia/SimpleDirectMediaLayer.jl#53. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new circle drawing algorithm completely fills in the circle, and as far as I know it works for all sizes of circles. It tends to be only about 2x - 3x slower than the previous algorithm. There has been an anomaly with it where there is a small bump on the top of the circle that looks about a pixel high, but other than that there appears to be no problems. The strange bump only occurs when
fill=truethough. Here are some pictures of the results.