Remove unnecessary DotProtoEmptyField constructor
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j6carey
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
This looks good, but it may be that DotProtoEmptyField was an (apparently unsuccessful) attempt to handle empty statements. Perhaps another PR could be created to add support for those, probably by making certain parsers return Maybe types and then applying catMaybes to the lists whose elements are returned by those parsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change improving the AST by removing the
DotProtoEmptyFieldconstructor from theDotProtoField. This constructor complicated the AST and was needed nowhere.