Skip to content

Commit

Permalink
Merge pull request #9 from moralesl/main
Browse files Browse the repository at this point in the history
Fix testing of CF template
  • Loading branch information
adamjkeller authored Jul 27, 2023
2 parents 969b692 + 19625b5 commit 162dc2c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 13 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
venv/
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,17 @@ Resources:
GroupDescription: Access to the public facing load balancer
VpcId: '{{environment.outputs.VpcId}}'
SecurityGroupIngress:
{% if 'public' == service_instance.inputs.scope %}
# Allow access to ALB from anywhere on the internet
- CidrIp: 0.0.0.0/0
IpProtocol: -1
{% else %}
# Allow access only from the VPC CIDR
- CidrIp: '{{environment.outputs.VpcCIDR}}'
IpProtocol: -1
FromPort: '{{service_instance.inputs.port}}'
ToPort: '{{service_instance.inputs.port}}'
{% endif %}
{% if 'public' == service_instance.inputs.scope %}
# Allow access to ALB from anywhere on the internet
- CidrIp: 0.0.0.0/0
IpProtocol: -1
{% else %}
# Allow access only from the VPC CIDR
- CidrIp: '{{environment.outputs.VpcCIDR}}'
IpProtocol: -1
FromPort: '{{service_instance.inputs.port}}'
ToPort: '{{service_instance.inputs.port}}'
{% endif %}

{% if 'public' == service_instance.inputs.scope %}
{% set scheme = 'internet-facing' %}
Expand All @@ -175,8 +175,8 @@ Resources:
Properties:
Scheme: '{{scheme}}'
LoadBalancerAttributes:
- Key: idle_timeout.timeout_seconds
Value: '30'
- Key: idle_timeout.timeout_seconds
Value: '30'
Subnets:
# The load balancer is placed into the public subnets, so that traffic
# from the internet can reach the load balancer directly via the internet gateway
Expand Down

0 comments on commit 162dc2c

Please sign in to comment.