-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Chat History Defaults to Spanish Despite English Language Selected #294
base: main
Are you sure you want to change the base?
BUG: Chat History Defaults to Spanish Despite English Language Selected #294
Conversation
- added param that interpolates a language for the model to use, or defaults to english - added a test that iterates through the languages supported by the project
Thank you for your contribution! May I ask you a few things?
@wadabee Please tell us if you have any good suggestion to reflect |
Black formatted
…phedward/bedrock-claude-chat into BUG-propose-title-language-
Yes @statefb I will make those modifications, might take me a few days to look at it closely. Lots of possibilities for further integrating language capabilities...you could make a literal with supported languages as the param, like you did with models. And you could do more to detect languages in real-time. Willing to work with @wadabee to introduce react-i18next in the frontend, could be interesting. |
@josephedward Thank you, that's totally no problem. Can I ask you about more detail what are you planning for another language feature?
react-i18next is already introduced. According to this stack overflow, we can get current language using |
I knew you were using i18n, didn't realize you were already using that specific library.
If this commit helps, go ahead and merge.
I will work on this soon if you want to keep this PR open 😊 |
No problem, this PR would be helpful and thank you again for your willingness for contribution! |
- added useTranslation hook to useConversationApi.ts - updated the interpolation text in propose_conversation_title in chat.py - added a URL segment corresponding to the lanugage param in conversaption.py
Issue #, if available: #240
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.