Fix: Nova doesn't work #645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the system prompt when doing 'Retrieved Context Citation' with Amazon Nova. - If the tool result has more than one element, pass it as single text content formatted as JSON array.
Yukinobu-Mine
force-pushed
the
629-bugnova-doesnt-work
branch
from
d6d3360 to
8023c93
Compare
Yukinobu-Mine
force-pushed
the
629-bugnova-doesnt-work
branch
from
8023c93 to
bae8d4e
Compare
statefb
reviewed
Dec 16, 2024
- `RemoveTitle` in app/agents/tools/agent_tool.py - `_prepare_nova_model_params()` in app/bedrock.py - `build_rag_prompt()` and `get_prompt_to_cite_tool_results()` in app/prompt.py - `BaseTool` -> `AgentTool` in docs/AGENT.md
- To avoid circular imports, add `from __future__ import annotations` and `if TYPE_CHECKING` to app/bedrock.py
- docs/AGENT.md
statefb
reviewed
Dec 17, 2024
| ] | ||
| from app.bedrock import is_nova_model | ||
|
|
||
| if is_nova_model(model=model): |
There was a problem hiding this comment.
前回のレビューで漏れてすみません！related_document.to_tool_result_modelにmodel渡して分岐する方が、同等の処理が一箇所にまとまるため可読性が良いとも思いましたが、いかがでしょうか？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #629
Description of changes:
topKto 128. 4ec0465titlekey from input JSON schema ofAgentTool. dd979e0By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.