Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add versioning #212

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

mikemcd3912
Copy link
Contributor

Issue #, if available:
#125

Description of changes:
Added label to the README for new labeling requirements
Updated partner Namespace files with the current versions based on available Helm chart versions
Updated Validated Partner files for each environment with the Version field and associated values

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mikemcd3912
Copy link
Contributor Author

mikemcd3912 commented Feb 12, 2024

GH Action failed because I updated the Validated Partners files outside of the normal reporting workflow, and is expected behavior

@mikemcd3912 mikemcd3912 linked an issue Feb 12, 2024 that may be closed by this pull request
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikemcd3912 Nice work, couple of comments. We should use Automation to update the Partner list with Versions. We should not update manually. And Reason why manifestJob was removed.

Validated_Partners/baremetal_Partners.txt Outdated Show resolved Hide resolved
Validated_Partners/snow_Partners.txt Outdated Show resolved Hide resolved
Validated_Partners/vsphere_Partners.txt Outdated Show resolved Hide resolved
@mikemcd3912
Copy link
Contributor Author

I pulled ManifestJob because it seemed like it was associated with testing and therefore would serve as a distraction from our current examples for ChronJobs in the Testers folder. Updated PR to remove that deletion only modify Version update files

@elamaran11
Copy link
Contributor

I pulled ManifestJob because it seemed like it was associated with testing and therefore would serve as a distraction from our current examples for ChronJobs in the Testers folder. Updated PR to remove that deletion only modify Version update files

It is a sample. I think our ReadMe references this if im not mistaken. Lets keep it as a source of sample to share to partners who ask. This helps us being not biased to share any particular partner sample to anyone!

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@elamaran11 elamaran11 merged commit dbdced4 into aws-samples:main Feb 16, 2024
2 checks passed
@elamaran11
Copy link
Contributor

Looks like your deployment dynatrace-dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-dynatrace-operator-6859dbbd89-7n2sx.

@mikemcd3912 mikemcd3912 deleted the feature/add-versioning branch May 9, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add partner software version to reporting.
2 participants